bcgov / sbc-pay

ServiceBC common payment services for one-time and long-enagement partners
Apache License 2.0
7 stars 39 forks source link

22655 - Wire in reverse_invoice for consolidated invoices #1702

Closed seeker25 closed 3 weeks ago

seeker25 commented 1 month ago

Issue #: https://github.com/bcgov/entity/issues/22655

Flows:

  1. EFT Client is overdue, they never navigate to the consolidation payments screen (NSF lock flow and don't hit the next button on credit card) - no cfs_invoice is created for consolidated invoice and no invoice_reference is created. They pay by regular EFT and it works.
  2. EFT Client is overdue, pay by credit card, creates and pays consolidated invoices and reverses the "regular" invoice, this should unlock the users.
  3. EFT Client is overdue they start the pay by credit card which creates a consolidated invoice, they eventually pay by EFT instead. The job is smart enough to realize they had a consolidated invoice, reverses that and completes payment on the "regular" invoice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

seeker25 commented 3 weeks ago

unit tests + CI fixes to go