21537 - Shortname Refunds - PATCH / GET methods & Notification

bcgov / sbc-pay

ServiceBC common payment services for one-time and long-enagement partners

Apache License 2.0

8 stars 39 forks source link

21537 - Shortname Refunds - PATCH / GET methods & Notification #1758

Closed seeker25 closed 1 month ago

seeker25 commented 1 month ago

Issue #: https://github.com/bcgov/entity/issues/21537

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

ochiu commented 1 month ago

Looks good so far! Thanks!

seeker25 commented 1 month ago

Need the notification too haha

ochiu commented 1 month ago

Looks good, just the one comment about the history.

I have also merged a PR with a fix to the tests, sorry that was my bad.