bcgov / shinyssdtools

Shiny interface to ssdtools R package
https://bcgov.github.io/shinyssdtools/
Apache License 2.0
7 stars 4 forks source link

se and CIs not calculated for model-averaged HC5 and lnormlnorm #110

Closed sebdalgarno closed 7 months ago

sebdalgarno commented 2 years ago

issue reported by Kathleen Mctavish:

this occurs when pboot is < 0.99. In the console the following warning is generated:

Warning message:
One or more pboot values less than 0.99 (decrease min_pboot with caution).'

reproduce in ssdtools with:

library(ssdtools)
library(ggplot2)
library(readr)

# read dataset
# the file argument of read_csv() assumes the file is in your working directory. You may need to change the file path to correctly read your dataset.
data <- read_csv(file = 'data3.csv')[1:20,]
# fix unacceptable column names
colnames(data) <- make.names(colnames(data))

# fit distributions
dist <- ssd_fit_dists(data, left = 'Effect.Concentration..µg.L.', dists = c('lnorm_lnorm'), silent = TRUE, reweight = FALSE, min_pmix = 0, nrow = 6L, computable = TRUE, at_boundary_ok = FALSE, rescale = TRUE)

ssd_hc(dist, percent = 5L, ci = TRUE, average = FALSE, nboot = 100L)

And can be fixed with:

ssd_hc(dist, percent = 5L, ci = TRUE, average = FALSE, nboot = 100L, min_pboot = 0)

Currently the warning about min_pboot is not exposed to the app user and there is also no option to adjust the min_pboot, leaving the user in the dark.

Perhaps we should expose the warning to the user and provide a min_pboot input?

sebdalgarno commented 7 months ago

this error no longer occurs in the app ![Uploading image.png…]()