bcgov / shinyssdtools

Shiny interface to ssdtools R package
https://bcgov.github.io/shinyssdtools/
Apache License 2.0
7 stars 4 forks source link

shinyssdtools now as R package #36

Closed sebdalgarno closed 4 years ago

sebdalgarno commented 4 years ago

This is a major overhaul of the ssdtools-shiny Shiny App. It is now an R package and is up to date with the latest release of ssdtools (V 0.2.0). Other features have been added as requested by Angeline Tillmanns.

Development occurred over at 'poissonconsulting/shinyssdtools'. In future, we will do development from a fork but in this case we have had to fork post-development and copy over the files in one go. This maintains git history of bcgov/ssdtools-shiny.

I have run the following:

roxygen2md::roxygen2md()
styler::style_pkg(filetype = c("R", "Rprofile", "Rmd"))
devtools::test()
devtools::document()
devtools::check()

There are 0 Errors, 0 Warnings, 0 Notes

I have modified the README.md file only slightly and have left the code of conduct and license files as they were.

Once the PR is merged, please rename the repository from 'bcgov/ssdtools-shiny' to 'bcgov/shinyssdtools' to match the R package name.

ateucher commented 4 years ago

Thanks @sebdalgarno - can you comment on how deployment differs now?

sebdalgarno commented 4 years ago

you can run 'deploy.R' script in the main directory (replace rsconnect::deployApp function arguments like 'account' and 'appName')

sebdalgarno commented 4 years ago

that picks up on the 'app.R' script in the main directory, which tells it where all of the shiny components are

ateucher commented 4 years ago

Ok, thanks @sebdalgarno. Does that pick up the config in the rsconnect folder? This PR removes the shinyApp/rsconnect/shinyapps.io/bcgov-env/ssdtools.dcf file..

sebdalgarno commented 4 years ago

right I see. Would you like me to move the rsconnect folder back?

ateucher commented 4 years ago

Yes I think so, thanks

sebdalgarno commented 4 years ago

done - also removed /rsconnect from gitignore

ateucher commented 4 years ago

Thanks @sebdalgarno!

sebdalgarno commented 4 years ago

thanks @ateucher can you please rename the repository to shinyssdtools?