search

bcgov / shinyssdtools

Shiny interface to ssdtools R package
https://bcgov.github.io/shinyssdtools/
Apache License 2.0
7 stars 4 forks source link

JOSS Review: Licence Template and Metadata Updates #58

Closed elimillera closed 3 years ago

elimillera commented 3 years ago

Per the JOSS review checklist:

License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?

  1. The Apache 2.0 license is included however the placeholders for the copyright holder and year haven't been updated. Line 189 in the LICENSE file: Copyright {yyyy} {name of copyright owner}

  2. The DESCRIPTION file in the top-level directory lists the file as MIT. If this is incorrect you can replace it with 'Apache License | file LICENSE' Line 9 in the DESCRIPTION file: License: MIT + file LICENSE

  3. The copyright holder doesn't appear in the list of "Authors" in the DESCRIPTION file. While this isn't a JOSS issue this would prevent submission to CRAN if you are planning on that. Here is how dplyr lists RStudio as the copyright holder. Line 4-7 in the DESCRIPTION file:

    Authors@R: c(
person("Joe", "Thorley", , "joe@poissonconsulting.ca", "ctb", comment = c(ORCID = "0000-0002-7683-4592")),
person("Sebastian", "Dalgarno", , "seb@poissonconsulting.ca", c("aut", "cre"), comment = c(ORCID = "0000-0002-3658-4517"))
)
sebdalgarno commented 3 years ago

thanks @elimillera for the helpful and detailed comments. Should be all good now

elimillera commented 3 years ago

@sebdalgarno Are you planning on submitting into CRAN? Item three above doesn't look to be resolved. This is an issue specific to CRAN policies and I don't think this should hold up anything with JOSS. However, I have had a package get rejected from CRAN for this reason.

Thanks for the updates!

sebdalgarno commented 3 years ago

@elimillera no plans to submit to CRAN right now. But will keep this in mind if Province of BC requests that it be submitted to CRAN. Thanks!