bcgov / silviculture-ipc

Forestry Sector Operator Screening for Infection Prevention and Control Protocols. Being replaced by: https://github.com/bcgov/common-forms-toolkit

https://github.com/bcgov/common-forms-toolkit

Apache License 2.0

1 stars 8 forks source link

Let Inspector edit a form submission #103

Closed TimCsaky closed 4 years ago

TimCsaky commented 4 years ago

Description

Allow an Inspector to edit 'location details' of a form submission. (on the admin > submission review page, see 'edit submission' button)

this also addresses ticket 1112

Types of changes

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

TimCsaky commented 4 years ago

for some reason the city look up field isnt populated in the edit form.. or the main form when a user goes back to update

TimCsaky commented 4 years ago

i wasnt able to pass the store name as a property to the child Location component. i tried some of the things here but had no luck: https://stackoverflow.com/questions/42585055/pass-prop-as-module-name-when-mapping-to-namespaced-module

I'm thinking this will work with the single store. and frankly, i cant waste another day trying to get it working.

now.. the only issue i see is that teh city lookup combobox isnt populated. i'm not sure if i need another listener in there or what. i tried a few things but had no luck. I'd love to know if you see anything obvious I'm missing.

i've been going a little crazy with this ticket. learnt some vue stuff.. but it sure is dragging on.

loneil commented 4 years ago

I see the sort order working, and the city lookup working on this PR. What's the problem with those?

TimCsaky commented 4 years ago

I see the sort order working, and the city lookup working on this PR. What's the problem with those?

for me (both on my local and in the pr, both rebased with dev master), i see the submission table sorted created ASC (latest submission in the last row). when an inspector goes to the edit location modal, the city look up field doesnt show the city.

on a side note.. in a previous commit i made my code for the home (logo and tile) links in the banner a bit more succinct using <view-router> element. this broke the BCGovHeader unit test so i reverted that. not sure it's worth spending more time on that.