Operation Type - temporary fix

[TimCsaky]

Description

• Added 'operation type' dropdown to the silviculture form it just saves as a string to a new column 'operationType' in the 'ipc_plan' db table on the pdf and submission review page, a display name is derived from a hardcoded map.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

• [x] I have read the CONTRIBUTING doc
• [x] I have checked that unit tests pass locally with my changes
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added necessary documentation (if appropriate)

Further comments

[loneil]

There's a potential edge case for this (I just tested it out on this PR). The API and DB are updated, but the user is still holding the form in their browser without the operation type filled in. If this happens and the field is filled as NULL then it appears to fail loading on the submission page for the application.

Now, I'm not clear on in this case if the Model default will handle it in sequelize and set that to Silv, but that might matter depending on it what's posted has '' for the type value, or doesn't pass the field to the API from the front end if it's not present.

Regardless, it's probably best, since this is a nullable field, to make sure the Submission admin page can handle the case where it's null to be safe. Otherwise it's an unrecoverable state with only a client side error. The PDF seems to be fine in this case. Can see what I mean at https://silviculture-ipc-dev.pathfinder.gov.bc.ca/pr-111/#/admin/submission/9a471fde-bd0d-4a35-86f2-25a3a7e3eb3d

Also should bump the form version number for this change, that should be done for any field changes like this (it's what we can use to troubleshoot problems like above)

[TimCsaky]

There's a potential edge case for this (I just tested it out on this PR). The API and DB are updated, but the user is still holding the form in their browser without the operation type filled in. If this happens and the field is filled as NULL then it appears to fail loading on the submission page for the application.

Now, I'm not clear on in this case if the Model default will handle it in sequelize and set that to Silv, but that might matter depending on it what's posted has '' for the type value, or doesn't pass the field to the API from the front end if it's not present.

Regardless, it's probably best, since this is a nullable field, to make sure the Submission admin page can handle the case where it's null to be safe. Otherwise it's an unrecoverable state with only a client side error. The PDF seems to be fine in this case. Can see what I mean at https://silviculture-ipc-dev.pathfinder.gov.bc.ca/pr-111/#/admin/submission/9a471fde-bd0d-4a35-86f2-25a3a7e3eb3d

Also should bump the form version number for this change, that should be done for any field changes like this (it's what we can use to troubleshoot problems like above)

good catch!