Update RPD Buildings and EVCS Stalls layers

[michaelpnelson]

@bethbyoung , just giving you an update on this at the end of my day :) .

I have the EVCS layer looking good in local testing. It looks like, for stall type, the EVCS type was replaced with "Employee/Public", so it looks like this (don't mind the missing base map - I didn't have my Esri API key loaded) ...

I am having difficulty with the new RPD Buildings layer file - it doesn't show any points at all for me at present. I'm diagnosing the issue but it looks like something might be awry in the file data. If I trim away most of the features in the file I can see points. I should know more soon.

[bethbyoung]

Hi Michael,

Thanks for getting to work on this so quickly. I looked at the buildings, and it looks like the projection did not come over correctly. I have attached a revised version. Please let me know if you have any issues with this one.

Thanks, Beth

From: Michael Nelson @.> Sent: Thursday, March 30, 2023 4:06 PM To: bcgov/smk-clean-bc @.> Cc: Young, Elizabeth CITZ:EX @.>; Mention @.> Subject: Re: [bcgov/smk-clean-bc] Update RPD Buildings and EVCS Stalls layers (Issue #111)

[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

@bethbyounghttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbethbyoung&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7C27ef08e9371e4a830b8b08db317353c9%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158143609232327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eHo1P%2FMz23VfOYuSSLRt%2F1zgNJh9yjEZnjsfGiPQoik%3D&reserved=0 , just giving you an update on this at the end of my day :) .

I have the EVCS layer looking good in local testing. It looks like, for stall type, the EVCS type was replaced with "Employee/Public", so it looks like this (don't mind the missing base map - I didn't have my Esri API key loaded) ...

[Screenshot 2023-03-30 at 4 00 22 PM]https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F1911540%2F228983490-627d0c37-48ce-490b-b451-66b367369ab2.png&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7C27ef08e9371e4a830b8b08db317353c9%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158143609232327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vyUVoLrC4PaAwqY9o3GjwsMYVr%2BY2QZmCTszEjmXWhQ%3D&reserved=0

I am having difficulty with the new RPD Buildings layer file - it doesn't show any points at all for me at present. I'm diagnosing the issue but it looks like something might be awry in the file data. If I trim away most of the features in the file I can see points. I should know more soon.

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Fsmk-clean-bc%2Fissues%2F111%23issuecomment-1491077799&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7C27ef08e9371e4a830b8b08db317353c9%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158143609232327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Pjs1nzGWzHuTml5fA43CDBDui3hxiZanFSqETLGGukM%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA5J2EJJOAUFWMM6MLVVJB5TW6YGVPANCNFSM6AAAAAAWN2URNI&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7C27ef08e9371e4a830b8b08db317353c9%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158143609232327%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nGa5fqc6AwUmvoxaWtgxoEklA%2FmkPZAhFEpz%2BoT7t%2Bo%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

[michaelpnelson]

Hi @bethbyoung . Thanks for finding the projection issue with the RPD Buildings layer; it would have taken me much longer :) .

I didn't receive the attachment with the updated RPD Buildings layer. Could you either create a comment in this GitHub issue (https://github.com/bcgov/smk-clean-bc/issues/111) and attaching it to the comment, or email me directly with the layer attached? Thanks ...

[bethbyoung]

Hi Michael,

I tried to attach the geoson to the github comment section previously, but it said it didn’t support that file type. I also had the geojson attached in the last email message, so weird you couldn’t see it. I have attached it again, let me know if you still are unable to view it.

Thanks, Beth

From: Michael Nelson @.> Sent: Friday, March 31, 2023 9:20 AM To: bcgov/smk-clean-bc @.> Cc: Young, Elizabeth CITZ:EX @.>; Mention @.> Subject: Re: [bcgov/smk-clean-bc] Update RPD Buildings and EVCS Stalls layers (Issue #111)

[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

Hi @bethbyounghttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbethbyoung&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cd9578b232676412ffabe08db3203b582%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158763723793716%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LASAjYF2IKwcE8BWgCxo6rK9WlViIP%2FuMorUukaUCtg%3D&reserved=0 . Thanks for finding the projection issue with the RPD Buildings layer; it would have taken me much longer :) .

I didn't receive the attachment with the updated RPD Buildings layer. Could you either create a comment in this GitHub issue (#111https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Fsmk-clean-bc%2Fissues%2F111&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cd9578b232676412ffabe08db3203b582%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158763723793716%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=L4q8L9klzhcJl6gZuUPc5j7K63lqUh%2BJqxRjuK4vi3Y%3D&reserved=0) and attaching it to the comment, or email me directly with the layer attached? Thanks ...

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Fsmk-clean-bc%2Fissues%2F111%23issuecomment-1492223021&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cd9578b232676412ffabe08db3203b582%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158763723793716%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RpYdljvfMFCOjKOYROHvVgi9GImNA3cZVcnQjxZdLrw%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA5J2EJPGH4XR42N7LE7TUFLW637ZFANCNFSM6AAAAAAWN2URNI&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cd9578b232676412ffabe08db3203b582%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158763723793716%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=REkGA2kQhvTkNr2gsK1XAvN7nISh9ngyWdI%2B3rHVTcM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

[michaelpnelson]

I think that when replying to a notification email from GitHub and including an attachment, the attachment doesn't make it into the GitHub issue.

Could you send a new email directly to me (michael.nelson@gov.bc.ca) with the attachment? Thanks ...

[michaelpnelson]

Thanks for the new RPD Buildings layer, @bethbyoung .

I can now see the points. It looks like there are fewer features in the newest version.

I'm also seeing considerable difference between the feature attributes, especially between the first and second attachment you sent. Here's the same feature across 3 versions of the layer file - current, first attachment, and second attachment:

Current:

        {
            "type": "Feature",
            "id": 979,
            "geometry": {
                "type": "Point",
                "coordinates": [
                    -119.27072205704641,
                    50.26543210098277
                ]
            },
            "properties": {
                "FID": 979,
                "Bldng_ID": "B0067525",
                "Bldng_Type": "Office",
                "Address": "3201 30th St.",
                "City": "VERNON"
            }
        },

First attachment:

        {
            "type": "Feature",
            "id": 979,
            "geometry": {
                "type": "Point",
                "coordinates": [
                    10.496680976289595,
                    3.7760741265765514
                ]
            },
            "properties": {
                "FID": 979,
                "Bldg_ID": "B0014639",
                "Bldg_Type": "Office",
                "Address": "238 Government St",
                "City": "DUNCAN"
            }
        },

Second attachment:

        {
            "type": "Feature",
            "id": 979,
            "geometry": {
                "type": "Point",
                "coordinates": [
                    -123.71086059960466,
                    48.777545629149962
                ]
            },
            "properties": {
                "FID": 979,
                "Building_N": "B0014639",
                "Address": "238 Government St",
                "City": "DUNCAN",
                "Postal_Cod": "V9L1A5",
                "Region": "Vancouver Island",
                "Descriptio": "Round Bldg",
                "Tenure": "Leased",
                "Facility_T": "Courts",
                "Primary_Us": "Office",
                "Electoral_": "Cowichan-Ladysmith",
                "Complex_Nu": " ",
                "Land_Numbe": " ",
                "Usable_Are": 491.30000000000001,
                "Total_Rent": 717.10000000000002,
                "Parking_St": 13,
                "R_U_Ratio": 1.0415395787899999,
                "Strategic_": " ",
                "Constructi": " ",
                "In_Service": 775699200000,
                "Year_Built": 0,
                "Latitude": 48.777545629999999,
                "Longitude": -123.7108606,
                "lastupdate": "2023-03-29"
            }
        },

And I just now noticed that the features aren't the same as I initially thought, though they all have the same FID: the current layer has this in Vernon, while the next 2 layer version have this in Duncan.

We're currently displaying the attributes Building ID, Building Type, Address and City. For the second attachment, I we can use "Building_N" for Building ID. "Facility_T" seems like it might be the best match for Building Type, but it looks like the values for this field are empty for all features.

Is the second attachment one we want to move ahead with, or does it need further changes?

If it's helpful, I can deploy the second attachment to the development environment so you can inspect them.

Cheers

[bethbyoung]

Hi Michael,

Sorry, I forgot to adjust the attribute headings, thanks for the heads-up. I will send the revised geojson in a sec. Sorry about that.

From: Michael Nelson @.> Sent: Friday, March 31, 2023 10:26 AM To: bcgov/smk-clean-bc @.> Cc: Young, Elizabeth CITZ:EX @.>; Mention @.> Subject: Re: [bcgov/smk-clean-bc] Update RPD Buildings and EVCS Stalls layers (Issue #111)

[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

Thanks for the new RPD Buildings layer, @bethbyounghttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbethbyoung&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Ca82786881edf4918aa6908db320cf970%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158803522083467%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=i%2Fxnm9zIP8jbqXDmS96n8B3LBMP7YYRRsM0MGmOBD4Y%3D&reserved=0 .

I can now see the points. It looks like there are fewer features in the newest version.

I'm also seeing considerable difference between the feature attributes, especially between the first and second attachment you sent. Here's the same feature across 3 versions of the layer file - current, first attachment, and second attachment:

Current:

    {

        "type": "Feature",

        "id": 979,

        "geometry": {

            "type": "Point",

            "coordinates": [

                -119.27072205704641,

                50.26543210098277

            ]

        },

        "properties": {

            "FID": 979,

            "Bldng_ID": "B0067525",

            "Bldng_Type": "Office",

            "Address": "3201 30th St.",

            "City": "VERNON"

        }

    },

First attachment:

    {

        "type": "Feature",

        "id": 979,

        "geometry": {

            "type": "Point",

            "coordinates": [

                10.496680976289595,

                3.7760741265765514

            ]

        },

        "properties": {

            "FID": 979,

            "Bldg_ID": "B0014639",

            "Bldg_Type": "Office",

            "Address": "238 Government St",

            "City": "DUNCAN"

        }

    },

Second attachment:

    {

        "type": "Feature",

        "id": 979,

        "geometry": {

            "type": "Point",

            "coordinates": [

                -123.71086059960466,

                48.777545629149962

            ]

        },

        "properties": {

            "FID": 979,

            "Building_N": "B0014639",

            "Address": "238 Government St",

            "City": "DUNCAN",

            "Postal_Cod": "V9L1A5",

            "Region": "Vancouver Island",

            "Descriptio": "Round Bldg",

            "Tenure": "Leased",

            "Facility_T": "Courts",

            "Primary_Us": "Office",

            "Electoral_": "Cowichan-Ladysmith",

            "Complex_Nu": " ",

            "Land_Numbe": " ",

            "Usable_Are": 491.30000000000001,

            "Total_Rent": 717.10000000000002,

            "Parking_St": 13,

            "R_U_Ratio": 1.0415395787899999,

            "Strategic_": " ",

            "Constructi": " ",

            "In_Service": 775699200000,

            "Year_Built": 0,

            "Latitude": 48.777545629999999,

            "Longitude": -123.7108606,

            "lastupdate": "2023-03-29"

        }

    },

And I just now noticed that the features aren't the same as I initially thought, though they all have the same FID: the current layer has this in Vernon, while the next 2 layer version have this in Duncan.

We're currently displaying the attributes Building ID, Building Type, Address and City. For the second attachment, I we can use "Building_N" for Building ID. "Facility_T" seems like it might be the best match for Building Type, but it looks like the values for this field are empty for all features.

Is the second attachment one we want to move ahead with, or does it need further changes?

If it's helpful, I can deploy the second attachment to the development environment so you can inspect them.

Cheers

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Fsmk-clean-bc%2Fissues%2F111%23issuecomment-1492318822&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Ca82786881edf4918aa6908db320cf970%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158803522083467%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TM9DN79pGhrhFBkMStmzAVSqY9yhwtKVxSOg0eAwvHU%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA5J2EJOYELRRSJAAAGI4SW3W64HR3ANCNFSM6AAAAAAWN2URNI&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Ca82786881edf4918aa6908db320cf970%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158803522083467%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6A4Gl0BxUugUnw9Ovc24v8cEBhG11zR65oam8LlXB%2Fg%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

[michaelpnelson]

@bethbyoung , thanks for the new RPD Buildings layerfile. I've deployed it, as well as the EVCS layerfile, plus config changes as needed, to our dev environment:

https://cleanbcfleet-dev.apps.gov.bc.ca/

You can compare this against our prod environment:

https://cleanbcfleet.apps.gov.bc.ca/

It would be great if you could kick the tires a bit, and if the layer updates look good to you, let me know and I'll merge the changes and deploy to production.

[bethbyoung]

It looks good to me, thanks. On another note, I saw that the route line doesn’t change to a lighter colour after the range limit is exceeded. Is that going to be added in again?

From: Michael Nelson @.> Sent: Friday, March 31, 2023 11:26 AM To: bcgov/smk-clean-bc @.> Cc: Young, Elizabeth CITZ:EX @.>; Mention @.> Subject: Re: [bcgov/smk-clean-bc] Update RPD Buildings and EVCS Stalls layers (Issue #111)

[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

@bethbyounghttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbethbyoung&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Ca7e725d031ef4984bf1208db32156b8b%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158839796760159%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XzRyY96ZUzDT03sLA8JVm8%2F6GXhJfkYnSfL1T%2Fs8Y98%3D&reserved=0 , thanks for the new RPD Buildings layerfile. I've deployed it, as well as the EVCS layerfile, plus config changes as needed, to our dev environment:

https://cleanbcfleet-dev.apps.gov.bc.ca/

You can compare this against our prod environment:

https://cleanbcfleet.apps.gov.bc.ca/

It would be great if you could kick the tires a bit, and if the layer updates look good to you, let me know and I'll merge the changes and deploy to production.

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Fsmk-clean-bc%2Fissues%2F111%23issuecomment-1492416705&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Ca7e725d031ef4984bf1208db32156b8b%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158839796760159%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BE6xugUbASMMAbBmVYTCR1KwSSTl8gd%2BGMsGZBWZCtM%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA5J2EJJV7JXITLPRM3F4EK3W64OUTANCNFSM6AAAAAAWN2URNI&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Ca7e725d031ef4984bf1208db32156b8b%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158839796760159%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PM4Q%2FGp2f52b0XTSnYB88aEK3im4YWe2vKdW4G795PA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

[michaelpnelson]

Thanks @bethbyoung . I'll move the layer updates into production.

The route line changes are coming. When I demoed them I was running the changes locally. The change is made in the base SMK project however (https://github.com/bcgov/smk). I've already merged the changes there. @JJGov is also working on design suggestions for the styling of the line segments. The Clean BC app doesn't show these changes yet because I haven't made an SMK release including the line changes. The Clean BC app currently consumes SMK version 1.1.8. I'll be releasing 1.1.9 before our sprint ends (next Wednesday) and I'll be getting as many improvements as I can into that release.

[bethbyoung]

Sounds good, thanks for the explanation.

From: Michael Nelson @.> Sent: Friday, March 31, 2023 11:43 AM To: bcgov/smk-clean-bc @.> Cc: Young, Elizabeth CITZ:EX @.>; Mention @.> Subject: Re: [bcgov/smk-clean-bc] Update RPD Buildings and EVCS Stalls layers (Issue #111)

[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

Thanks @bethbyounghttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbethbyoung&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cf0c632c2719c4a46dd5408db3217b3b7%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158849591050019%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9TRE9ekgKfp2ddmmiKZGK2VWcrRz2hbqDbvfpDHwpdI%3D&reserved=0 . I'll move the layer updates into production.

The route line changes are coming. When I demoed them I was running the changes locally. The change is made in the base SMK project however (https://github.com/bcgov/smkhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Fsmk&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cf0c632c2719c4a46dd5408db3217b3b7%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158849591050019%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=69QULtApyuefUl1PgYI3IQCL8azyeSmjEu6UXWnZXcQ%3D&reserved=0). I've already merged the changes there. @JJGovhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJJGov&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cf0c632c2719c4a46dd5408db3217b3b7%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158849591050019%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IEiENy1HA0kz%2BMC%2FsbuJBfvpSGF1SCs2SGbi4xjba%2F0%3D&reserved=0 is also working on design suggestions for the styling of the line segments. The Clean BC app doesn't show these changes yet because I haven't made an SMK release including the line changes. The Clean BC app currently consumes SMK version 1.1.8. I'll be releasing 1.1.9 before our sprint ends (next Wednesday) and I'll be getting as many improvements as I can into that release.

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Fsmk-clean-bc%2Fissues%2F111%23issuecomment-1492435609&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cf0c632c2719c4a46dd5408db3217b3b7%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158849591050019%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=a8NUx%2F7Sq1RGLiyleD7tQkK4%2BByY0L9C9B6WWKZcleo%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA5J2EJIHK2DTSNVMLI62CZ3W64QR5ANCNFSM6AAAAAAWN2URNI&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cf0c632c2719c4a46dd5408db3217b3b7%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158849591050019%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9rzBHB92XhE0Tv%2Fbm9KIJD9YMfObqgQcz0ZClBAxmg8%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

[michaelpnelson]

@bethbyoung , I also noticed an inconsistency ... the attribute we use for the feature title is different between the EVCS and RPD Building layers - we use Building ID for RPD and Stall Type for EVCS. I think we should update configuration so that Building ID is used for EVCS as well. What do you think? If you agree I'll create an issue to implement this change.

[bethbyoung]

After you have added in the new attributes for Network, Number and Charger ID, based on the email from yesterday, we can update it to the Charger ID.

From: Michael Nelson @.> Sent: Friday, March 31, 2023 11:47 AM To: bcgov/smk-clean-bc @.> Cc: Young, Elizabeth CITZ:EX @.>; Mention @.> Subject: Re: [bcgov/smk-clean-bc] Update RPD Buildings and EVCS Stalls layers (Issue #111)

[EXTERNAL] This email came from an external source. Only open attachments or links that you are expecting from a known sender.

@bethbyounghttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbethbyoung&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cfb23f8ad02744229005408db321851c7%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158852246729746%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sLEj0TfpqyUMqx2kAbQKLEosmRZleEPanUXDetWmZ1M%3D&reserved=0 , I also noticed an inconsistency ... the attribute we use for the feature title is different between the EVCS and RPD Building layers - we use Building ID for RPD and Stall Type for EVCS. I think we should update configuration so that Building ID is used for EVCS as well. What do you think? If you agree I'll create an issue to implement this change.

[Screenshot 2023-03-31 at 11 43 09 AM]https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F1911540%2F229204329-268e4b90-69a4-4660-b458-d078e3b944e6.png&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cfb23f8ad02744229005408db321851c7%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158852246729746%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oqu9QalawJ9zFhWtHNzWS0qnUomYXbybXNO0H%2BtKZ%2FI%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2Fsmk-clean-bc%2Fissues%2F111%23issuecomment-1492440946&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cfb23f8ad02744229005408db321851c7%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158852246729746%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mIe1GxnTdSIbhqN8W6LojHJM678IS%2BBbFpVou0zmCVU%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA5J2EJLCA4PYXXVZEKON4B3W64RCPANCNFSM6AAAAAAWN2URNI&data=05%7C01%7Celizabeth.young%40gov.bc.ca%7Cfb23f8ad02744229005408db321851c7%7C6fdb52003d0d4a8ab036d3685e359adc%7C0%7C0%7C638158852246729746%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IfytPq1gfmMGayjqQbaGZlzlMbqH1KF6ei6deabKEYo%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

[michaelpnelson]

@bethbyoung , thanks for clarifying - I missed that part :) . I'll work on an update to include Network, Number and Charger ID this afternoon.

[michaelpnelson]

@bethbyoung , the attributes in the EVCS layer have been updated and pushed to dev and prod.

Cheers