bcgov / smk-cli

The Command Line Interface enables users to rapidly create and edit SMK map configuration, including data consumption via OGC and Esri ReST data access services and local data files.
https://bcgov.github.io/smk-cli
Apache License 2.0
5 stars 3 forks source link

Remove Measure tool from create #104

Closed michaelpnelson closed 1 year ago

michaelpnelson commented 1 year ago

The leaflet-measure library, which the Measure tool is built around, stopped working properly when the leaflet library was updated in SMK 1.1.2. This change prevents enabling the Measure tool when creating an SMK app. It also updates documentation to show that it is deprecated.

michaelpnelson commented 1 year ago

Just to give more context ... leaflet-measure (https://github.com/ljagis/leaflet-measure) was last updated in 2018, and when we updated leaflet from 1.7 to 1.9, this stopped working properly. I have not found a way to address this in SMK code. We can rewrite the tool to work with a better supported library (perhaps from the list in https://leafletjs.com/plugins.html#measurement) at some future point. Fuller context is in MAP-4904.