bcgov / smk-legacy-ui

Legacy Admin UI for the SMK has been de-supported. Please see the CLI under https://github.com/bcgov/smk for an alternative.
Apache License 2.0
8 stars 3 forks source link

Search - Search by Attribute UI #45

Closed NicoledeGreef closed 6 years ago

NicoledeGreef commented 6 years ago

Very similar to existing DMF applications - see BC Parks as an example.

cpspicer commented 6 years ago

Link to DMF in Test: https://test.apps.gov.bc.ca/ext/dmf-wizard/

cpspicer commented 6 years ago

for board

NicoledeGreef commented 6 years ago

dependency on connectivity to MPCM endpoint. #80

cpspicer commented 6 years ago

Lets set up a design session and discuss

cpspicer commented 6 years ago

Looking good. A few quick observations: 1) Can't find option to have the app poll the service to determine live contents for drop down lists (maybe need instructions?) 2) Would be nice to have an option for the author to choose an attribute to display along with the returned feature lists. Similar to DMF returned results list: image

3) Tool is described as a 'Filter by' in the UI. Should we change this to 'Search using'?

image

4) Execute text could be changed to 'Search'

5) Could add a clear button in UI

qqnluaq commented 6 years ago

There is a configuration property to set the 'title attribute', ie the atttribute that is shown in the list above. This needs to be exposed in the admin UI.

dhlevi commented 6 years ago

Re the first issue on @cpspicer comment above:

We've added a button in the admin UI to pull values. Currently it's activated for WMS features, and on a follow up next week we'll add in vector. I took a dive into the DMF code and it looks like it's configured to use the ArcGIS service calls to populate the list (geoprocess tools should let us get around the query limits), so we can use that same method (not always ideal as it is possible for it to miss values on large datasets, but I'll try and work out a sensible query).

However, because we want this to automatically update on the client side, I think this code should be removed from the Admin UI and moved into the client. On startup, the client could attempt to fetch a list that will always be up to date for a dropdown attribute.

cpspicer commented 6 years ago

Agree code should be client side, with a mode option setting in the author.

cpspicer commented 6 years ago

QA Failure. App builder won't open the screen to configure Queries for a layer. e.g. Points of diversion. Clicking yields no response or error from the UI.

dhlevi commented 6 years ago

@cpspicer Caught a bug in the admin ui related to the removal of surround editor panel that's affecting all modal dialogs. It's been patched, will do a build/deploy by Monday at the latest so you should see this issue fixed shortly.

cpspicer commented 6 years ago

I can now create queries again - testing continues.

I can manually add drop down values for attributes, but the actual attribute values are blank when you click on the drop down to make a choice. The choices are there, and you can select a seemingly blank entry. If you hit return the drop down box opens, but if you click in a text field and hit return the query will run and return results from that 'invisible' drop down attribute.

Also, still no toggle in the UI to have a drop down box fed from the live dataset for MPCM datasets.

image

I do like the new title attribute. Thanks for adding!

qqnluaq commented 6 years ago

The title for a parameter select choice is now optional, and will be derived from value if missing.

https://github.com/bcgov/smk/wiki/SMK-Client-Configuration#choices-select-layer-query-parameter

NicoledeGreef commented 6 years ago

The queries are working well. The UI styling needs a little bit of tweaking. See "Assisted Living..." site". At 100% zoom level in chrome the Query and results panel is cut-off due to the number of attributes listed, and the Title is displaced upwards.

image

Would like to decrease the font-size for the Title and for the choices in the drop-down boxes as well. Can this be done through the .css?

cpspicer commented 6 years ago

Linked to #193

NicoledeGreef commented 6 years ago

addition of scrollbar would perhaps alleviate some of the stretch trouble with the lengthy query form.

cpspicer commented 6 years ago

Good solution @qqnluaq

cpspicer commented 6 years ago

link to #242

cpspicer commented 6 years ago

closing this issue - moving 242 into the backlog