search

bcgov / smk-mrdt

An SMK app for determining Municipal Regional District Tax rates.
Apache License 2.0
0 stars 0 forks source link

Fix attribute display #26

Closed dgboss closed 2 years ago

dgboss commented 2 years ago

link to demo deployment of your smk based app is https://smk-mrdt-rt-b16795-dev.apps.silver.devops.gov.bc.ca

Verify that it looks good, if so merge the pull request which will trigger a prod deployment, otherwise close the pull request without merging

mentions / notifications: @dgboss, @NicoledeGreef

dgboss commented 2 years ago

The Vanity URL for the dev deploy is https://smk-mrdt-api-gov-bc-ca.test.api.gov.bc.ca

If this is a dev deploy, verify that it looks good, then merge the pull request to trigger prod deployment.

If this is a prod deployment, view your prod deploy at the url above :)

mentions / notifications: @dgboss, @NicoledeGreef

dgboss commented 2 years ago

I'll take a look and see if there is an updated version of the code editor that would allow us to have a 'condensed' version of the HTML in the smk-config.json, but allow us to easily beautify the HTML for editing purposes.

michaelpnelson commented 2 years ago

Arg! :) Almost there ... without the newlines, the spaces are in the same line now, so divs are indented further:

<div class="smk-body">
    <div class="smk-feature">
              <div class="smk-layer">
            Municipal Regional District Tax: 3%
        </div>
        <div class="smk-attributes">
            <div class="smk-attribute">
                <span class="smk-attribute-title">
                    Recipient:
                </span>
                <span>
                    <span class="smk-value">
                        {{feature.properties.Recipient}}
                    </span>
                </span>
            </div>
            <div class="smk-attribute">
                <span class="smk-attribute-title">
                    Tax Rate:
                </span>
                <span>
                    <span class="smk-value">
                        {{feature.properties.Tax_Rate}}
                    </span>
                </span>
            </div>
            <div class="smk-attribute">
                <div class="smk-attribute">
                    <span class="smk-attribute-title">
                        Area:
                    </span>
                    <span>
                        <span class="smk-value">
                            {{feature.properties.Accom_Area}}
                        </span>
                    </span>
                </div>
            </div>
            <div class="smk-attribute">
                <div class="smk-attribute">
                    <span class="smk-attribute-title">
                        Start date:
                    </span>
                    <span>
                        <span class="smk-value">
                            {{feature.properties.MRDT_Start_Date}}
                        </span>
                    </span>
                </div>
            </div>
                 </div>
    </div>
</div>
dgboss commented 2 years ago

Removed the extra whitespace. Note that it is better to reply to comments inline that create new comments in order to maintain context/continuity.

I also looked at the editor, there is a 'beautify' button, but it is very basic and doesn't do a good enough job IMHO.

dgboss commented 2 years ago

I'm going to do a bit of a test by closing this PR and seeing what image gets deployed. I have a feeling it will be an image that doesn't include the changes resulting from the PR review.

dgboss commented 2 years ago

link to demo deployment of your smk based app is https://smk-mrdt-rt-b16795-prod.apps.silver.devops.gov.bc.ca

Verify that it looks good, if so merge the pull request which will trigger a prod deployment, otherwise close the pull request without merging

mentions / notifications: @dgboss, @NicoledeGreef

dgboss commented 2 years ago

The Vanity URL for the prod deploy is https://smk-mrdt.api.gov.bc.ca

If this is a dev deploy, verify that it looks good, then merge the pull request to trigger prod deployment.

If this is a prod deployment, view your prod deploy at the url above :)

mentions / notifications: @dgboss, @NicoledeGreef

dgboss commented 2 years ago

The Vanity URL for the dev deploy is https://smk-mrdt-api-gov-bc-ca.test.api.gov.bc.ca

If this is a dev deploy, verify that it looks good, then merge the pull request to trigger prod deployment.

If this is a prod deployment, view your prod deploy at the url above :)

mentions / notifications: @dgboss, @NicoledeGreef