search

bcgov / smk-tlink

The Truck Route Planner application for Translink built using the Simple Map Kit.
Apache License 2.0
2 stars 4 forks source link

tlink-246 add heights to overhead-structure-without-height-marker #269

Closed michaelpnelson closed 1 year ago

michaelpnelson commented 1 year ago

Hi @qqnluaq . Just confirming - is this the only commit we would need to integrate to support overhead structures?

Also I'm seeing that creating this PR does not trigger a deploy to the test site - it looks like I'd have to create a PR that targets qa and merge it in order to trigger a test deploy. I may end up closing this PR and creating a PR that removes other commits from qa. Though the thought of it makes my head hurt :( ...

qqnluaq commented 1 year ago

Hi Michael, Can we talk about this on Teams after lunch? Say 1pm? -b

On Jun 29, 2023, at 11:22 AM, Michael Nelson @.***> wrote:

Hi @qqnluaq https://github.com/qqnluaq . Just confirming - is this the only commit we would need to integrate to support overhead structures?

Also I'm seeing that creating this PR does not trigger a deploy to the test site - it looks like I'd have to create a PR that targets qa and merge it in order to trigger a test deploy. I may end up closing this PR and creating a PR that removes other commits from qa. Though the thought of it makes my head hurt :( ...

— Reply to this email directly, view it on GitHub https://github.com/bcgov/smk-tlink/pull/269#issuecomment-1613602360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2V3K7TZPZ6TKH6IOPYOM3XNXBW5ANCNFSM6AAAAAAZY3FKRI. You are receiving this because you were mentioned.

michaelpnelson commented 1 year ago

Hi Michael, Can we talk about this on Teams after lunch? Say 1pm? -b … On Jun 29, 2023, at 11:22 AM, Michael Nelson @.***> wrote: Hi @qqnluaq https://github.com/qqnluaq . Just confirming - is this the only commit we would need to integrate to support overhead structures? Also I'm seeing that creating this PR does not trigger a deploy to the test site - it looks like I'd have to create a PR that targets qa and merge it in order to trigger a test deploy. I may end up closing this PR and creating a PR that removes other commits from qa. Though the thought of it makes my head hurt :( ... — Reply to this email directly, view it on GitHub <#269 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2V3K7TZPZ6TKH6IOPYOM3XNXBW5ANCNFSM6AAAAAAZY3FKRI. You are receiving this because you were mentioned.

That sounds fine. Thanks!

michaelpnelson commented 1 year ago

Closing this pull request as it does not include all the overhead structure commits. This is replaced by pull request https://github.com/bcgov/smk-tlink/pull/270