bcgov / traction

Traction is designed with an API-first architecture layered on top of Hyperledger Aries Cloud Agent Python (ACA-Py) and streamlines the process of sending and receiving digital credentials for governments and organizations.
https://digital.gov.bc.ca/digital-trust/tools/traction/
Apache License 2.0
52 stars 51 forks source link

Delete duplicated endorser service code, use ACA-Py with auto-endorsement #1251

Closed esune closed 1 month ago

esune commented 4 months ago

The Traction repo has code for an endorser that is out of date - https://github.com/bcgov/traction/tree/main/services/endorser. We should switch to reference and use the code in https://github.com/hyperledger/aries-endorser-service instead.

loneil commented 4 months ago

Other alternative could be to just use an endorser agent without the service on top? Is that possible/something that's lighter? Or are the service integrations needed.

On the other hand, having the service running when starting up the whole docker compose is then creating an ecosystem that matches our deployed/production real world Traction cases, so maybe that's better.

esune commented 4 months ago

Other alternative could be to just use an endorser agent without the service on top? Is that possible/something that's lighter? Or are the service integrations needed.

Actually that might be a better idea for Traction in Docker, since we just need to be able to endorse: we can run an ACA-Py agent with auto flags set and that would be good enough and simpler - good point!

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

shanmukh-777 commented 2 months ago

Hello,I have a doubt,Do i need to deploy endorser separately in Kubernetes and gives its alias to traction acapy agent or there is another way of directly giving ledger genesis and endorser did to traction while deploying using helmcharts,so it manages automatically by itself of endorsing transactions sent by tenants using the provided endorser did and ledger genesis.

shanmukh-777 commented 2 months ago

because in docker compose there is separate endorser agent but i am unable to find any scripts for endorser agent in helmcharts

esune commented 2 months ago

@shanmukh-777 you would have to deploy an endorser agent separately, or connect to an existing one. The endorser service included in the docker-compose file is just there to facilitate local development.

shanmukh-777 commented 2 months ago

@esune thanks for the confirmation,but is there any charts for aries-endorser-service kubernetes deployment

esune commented 2 months ago

@esune thanks for the confirmation,but is there any charts for aries-endorser-service kubernetes deployment

We do not have native k8s charts for it, but there are OpenShift templates you may be able to take inspiration from here

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

esune commented 1 month ago

Resolved by #1344