Closed Gavinok closed 1 month ago
Deployment | Resource | Location |
---|---|---|
Traction | ||
Tenant UI | https://pr-1294-traction-tenant-ui-dev.apps.silver.devops.gov.bc.ca | |
Innkeeper UI | https://pr-1294-traction-tenant-ui-dev.apps.silver.devops.gov.bc.ca/innkeeper | |
Aca-Py | ||
Admin Swagger | https://pr-1294-traction-acapy-admin-dev.apps.silver.devops.gov.bc.ca/api/doc | |
Tenant Proxy Swagger | https://pr-1294-traction-tenant-proxy-dev.apps.silver.devops.gov.bc.ca/api/doc |
Deployment URLs ready for review.
We're having the "you must type your name" super-confirm on just soft deleting a tenant as the Innkeeper, so I think we should for sure have more than just the standard confirm Yes/No on the Tenant Profile page for a full wallet removal.
There was discussion in the past about having the soft-delete flag be done first and then after a certain amount of time enabling a permanent delete. But if we're exposing the endpoint to permanent delete then of course the tenant can call it themselves. (I guess that endpoint could check the soft-delete flag was set at the least)
Chatted with @esune we can do this:
/innkeeper/tenants/{id}
endpoint that the Tenant can call, or first can check if setting the delete flag can be done with PUT /tenant/wallet
can be used for this?The soft delete is really just setting a flag at this time so we are adding a couple tickets for enhancement to that behaviour that can be picked up after this is done (can proceed with the above changes just using the existing soft delete behaviour)
Updated the ui and added support for soft deleting tenants
Here is the warning shown when permanently delete is selected
This same prompt is now also used for tenants as well
I had thought about making it red as well but figured all the warnings would deter people from accidentally clicking it. I will change it now
Yes let's fix the width of this button for sure
Updated tenant deletion button
Not exactly related to this PR but just confirming data deletion after tenant hard delted
Note this is for the current Traction mode of all wallets in the single database, going to check locally running in multi-DB mode.
This PR resolves #1253
I have added acapy endpoints for hard deleting tenants for both the innkeeper to delete any tenant and the tenant to delete themselves. I have also exposed this function in the UI
For the innkeeper it's simply a check box
For the tenant a new button has been added to the profile page which will then prompt the user for confirmation.