bcgov / trust-over-ip-configurations

OpenShift build and deployment configurations for the Trust Over IP components.
Apache License 2.0
4 stars 10 forks source link

Update issuer-agent build to include DRPC plug-in #243

Closed esune closed 1 month ago

esune commented 1 month ago

Base image version could be one minor lower (0.12.1), however I do not think it would be beneficial to start with an older release since agents wanting to use the protocol will need to be updated any way.

Build/deployments have not yet been updated: @WadeBarnes I will want to sync-up with you if I work on those as I know there's a versioning pattern that needs to be respected.

esune commented 1 month ago

@WadeBarnes I added the startup parameter I was missing to enable the plugin in ACA-Py. I was debating on whether to make this a configurable setting, however I think that it would be adding unnecessary complexity for something like this so went with the "always on" type of approach.

esune commented 1 month ago

@WadeBarnes thanks for the tip, updated the PR with the appropriate changes.

I only updated the param files for the IDIM agents since I am not aware of other agents requiring this, and because there are profiles that are now outdated/unused (should we prune them?). We can update other profiles as we go through them.

WadeBarnes commented 1 month ago

I only updated the param files for the IDIM agents since I am not aware of other agents requiring this, and because there are profiles that are now outdated/unused (should we prune them?). We can update other profiles as we go through them.

Yes, we should prune the one's we've decommissioned.

esune commented 1 month ago

I only updated the param files for the IDIM agents since I am not aware of other agents requiring this, and because there are profiles that are now outdated/unused (should we prune them?). We can update other profiles as we go through them.

Yes, we should prune the one's we've decommissioned.

👍🏻 - it will be in a separate PR as there likely are several profiles that need reviewing/auditing.