bcgov / vc-authn-oidc

Apache License 2.0
143 stars 74 forks source link

Use production Vue #534

Closed loneil closed 4 months ago

loneil commented 4 months ago

The embedded vue CDN import is pulling <script src="https://unpkg.com/vue@3/dist/vue.global.js"></script> which is the development un-minified Vue library. This will log out a warning in the console:

You are running a development build of Vue.
Make sure to use the production build (*.prod.js) when deploying for production.

As well, the vue@3/dist link will actually get the latest release Vue it appears, leaving open to possible production runtime bugs if a newer Vue version alters something that changes behaviour on the page. So pin to a specific Vue version.

Change to vue@3.4.27/dist/vue.global.prod.js to use the (much smaller) prod minified file and pin to 3.4.27.