bcgov / von-network

A portable development level Indy Node network.
Apache License 2.0
163 stars 188 forks source link

Document how to enable TAA, add support for enabling on startup #150

Closed WadeBarnes closed 3 years ago

WadeBarnes commented 3 years ago

Document the process for enabling a TAA in von-network. For bonus points add support for enabling the TAA as a startup option.

Here is the process to enable TAA in von-network:

jcourt562 commented 3 years ago

I can probably take this. I want to get this working anyway for the SDK we publish using VON so it would be better to get it going in the public repo than something we craft individually. It will also make the devel environment closer to the experience using the Public ledgers so thats a big win IMHO.

swcurran commented 3 years ago

That would be great. I've been debating if we should automatically activate it on VON-Network and/or BCovrin. Would break things, but makes stuff more realistic.

If you can add an option on ./manage start to activate the TAA, that would be very cool...

jcourt562 commented 3 years ago

@swcurran yep I can do that. I use VON so much it would be silly not to contribute to it :-)

jcourt562 commented 3 years ago

@swcurran looking at the code it would seem that since the TAA addition requires a rebuild of the images it makes more sense to add the option to ./manage build and ./manage rebuild. I am thinking of a -taa switch which if present will build the sample_aml.json and sample_taa.json into the images as @WadeBarnes has described. Did you specifically want it to be part of the ./manage start or is this an acceptable approach ?

jcourt562 commented 3 years ago

@swcurran actually maybe the comment that a rebuild is necessary isn't true. Looks like the docker-compose.yml is mounting the ./config for the webserver not just including it in the von-network-base image that is built.

jcourt562 commented 3 years ago

I have submitted the code changes to get this to work and hopefully not trounce on instances where a user has already created their own aml.json and taa.json on shutdown. Not sure what documentation area really needs changing. I updated the manage usage instructions to point people at the config/ files. It seems pretty clear once you look at the config/ files what can go in them.

WadeBarnes commented 3 years ago

Implemented in https://github.com/bcgov/von-network/pull/152