search

bcgov / workbc-cc

WorkBC Career Compass project
2 stars 2 forks source link

[WBCAMS-549] fix print theme #283

Closed jonathan-longe closed 2 months ago

jonathan-longe commented 2 months ago

Compare Careers page:

Screenshot (122)

Results pages:

Screenshot (119) Screenshot (120) Screenshot (121)

infojunkie commented 2 months ago

I'll let @rjkuyvenhoven do the review. Thanks!

rjkuyvenhoven commented 2 months ago

The results page is missing the subtitle "Find out about your key aptitudes..."

I guess the question is how closely do we want to match PROD. These results show the same information and structure as the PROD print. However, there are some sizing and alignment variations.

Some of the sizing changes (ie. results table) seem acceptable, while the Top Aptitudes card sizing may not be.

infojunkie commented 2 months ago

The results page is missing the subtitle "Find out about your key aptitudes..."

I guess the question is how closely do we want to match PROD. These results show the same information and structure as the PROD print. However, there are some sizing and alignment variations.

Some of the sizing changes (ie. results table) seem acceptable, while the Top Aptitudes card sizing may not be.

From my perspective, as long as we have more time to work on the theme, we can get closer to the original theme.

jonathan-longe commented 2 months ago

The results page is missing the subtitle "Find out about your key aptitudes..."

I guess the question is how closely do we want to match PROD. These results show the same information and structure as the PROD print. However, there are some sizing and alignment variations.

Some of the sizing changes (ie. results table) seem acceptable, while the Top Aptitudes card sizing may not be.

Thanks Ray, I'll add the missing subtitle and, if time permits, get the theme closer to the original.

jonathan-longe commented 2 months ago

@rjkuyvenhoven do you have any objection if I merge this PR? I'd like these changes to be visible to Geethu so I don't hold up her testing.

rjkuyvenhoven commented 2 months ago

@rjkuyvenhoven do you have any objection if I merge this PR? I'd like these changes to be visible to Geethu so I don't hold up her testing.

that's ok with me