bcgov / workbc-jb

WorkBC JobBoard
Apache License 2.0
2 stars 1 forks source link

[WBCAMS-508] remove safety from stored procedure #181

Closed jonathan-longe closed 2 months ago

jonathan-longe commented 2 months ago

The existing usp_GenerateJobSeekerStats stored procedure prevents the generated report data from being recreated until 12 hours has elapsed. This PR allows the report data to recreated at anytime. The safety code is no longer required since we run the SP on a schedule not as requested by users.

From this:

IF EXISTS (SELECT * FROM ReportPersistenceControl 
            WHERE TableName = @TableName 
            AND WeeklyPeriodId = @PeriodId 
            AND DateCalculated < @EndDatePlus1
            AND DateCalculated < DATEADD(HOUR,-12,GETDATE())) 
BEGIN 
    DELETE FROM ReportPersistenceControl 
    WHERE TableName = @TableName AND WeeklyPeriodId = @PeriodId;
    -- also delete associated record from JobSeekerStats
    DELETE FROM JobSeekerStats WHERE WeeklyPeriodId = @PeriodId;
END

To this:

DELETE FROM ReportPersistenceControl 
WHERE TableName = @TableName AND WeeklyPeriodId = @PeriodId;
-- also delete associated record from JobSeekerStats
DELETE FROM JobSeekerStats WHERE WeeklyPeriodId = @PeriodId;