search

bcgov / workbc-ssot

WorkBC single source of truth
Apache License 2.0
1 stars 1 forks source link

WBCAMS-307 update monthly_labour_market_update_no_city.php to handle new industries #22

Closed rjkuyvenhoven closed 11 months ago

rjkuyvenhoven commented 11 months ago

In addition to updated LMS data (November 2023) I've updated monthly_labour_market_update_no_city.php to handle the two new industries.

infojunkie commented 11 months ago

You didn't need to: That's what https://github.com/bcgov/workbc-ssot/blob/master/migration/monthly_labour_market_update_new_industries.php is there for.

If you update the older script, some of the older datasets might no longer work.

infojunkie commented 11 months ago

Also, please update migrate.sh to include the new sheet.

rjkuyvenhoven commented 11 months ago

You didn't need to: That's what https://github.com/bcgov/workbc-ssot/blob/master/migration/monthly_labour_market_update_new_industries.php is there for.

If you update the older script, some of the older datasets might no longer work.

We use this file instead of monthly_labour_market_update_no_city.php or in addition to?

infojunkie commented 11 months ago

We use this file instead of monthly_labour_market_update_no_city.php or in addition to?

We are using several versions of the same script, to match the variations in the incoming sheets. If you examine migrate.sh you will see that the 3 script variations are being used.

The latest one is monthly_labour_market_update_new_industries.php.

rjkuyvenhoven commented 11 months ago

ok, I see that now. I'm updating the readme as well.