bcgov / workbc-wage-subsidy

WorkBC intake form for Wage Subsidy.
Apache License 2.0
1 stars 1 forks source link

TECH-394: Admin client notifications #112

Closed npham49 closed 11 months ago

npham49 commented 11 months ago

Description of changes:

npham49 commented 11 months ago

For reviewing, please have the following ENVs added:

The ENV change is also reflected in the .env.sample. //TODO: On deployment to Dev, add all envs to deploymentConfig

npham49 commented 11 months ago

Nice, thanks! Added a few more comments, most of them are console.logs() :).

Should be resolved now @strdavis have a look when you got some time!!

strdavis commented 11 months ago

Thanks for this! It's looking good to me now. We should get 1 more review since there's a lot here, but otherwise I'm OK to approve.

sonarcloud[bot] commented 11 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
7.6% 7.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint