Representation charts bugged

bcgov / workforce-profile-tool

Workforce Profile tool

Apache License 2.0

5 stars 3 forks source link

Representation charts bugged #132

Closed hangler closed 3 years ago

hangler commented 3 years ago

Issues with the chart not displaying correctly (e.g., Office of the Premier, Mental Health & Addictions) -- and afterwards, chart will not display for any other group until moving to a different tab first

karmour commented 3 years ago

Confirmed in Edge. @stephanieyurchak can you confirm in Chrome?

stephanieyurchak commented 3 years ago

No it is not fixed. If I look at office of the premier, and deselect Women and Visible Minority (the groups that have data) then the chart renders strangely and continues to be "broken" if I re-select those groups or select another ministry. I have to refresh the page to view the chart correctly again.

karmour commented 3 years ago

Interesting - it looks fine in Edge even with those parameters. (For once, the Microsoft browser is not the LCM! ;-) ) @hangler can you investigate?

hangler commented 3 years ago

@stephanieyurchak Can confirm this happens with 2018 data, though 2020 works. Will work on a fix.

hangler commented 3 years ago

@stephanieyurchak @karmour OK, so this is not ideal, but it looks like the charting library has a problem when all data values are zero. I have replaced the chart with a message. Hope this addresses the problem adequately...

karmour commented 3 years ago

I'm ok with this solution! Moving to Final Tidying milestone.

hangler commented 3 years ago

This should be in the latest deployment.

karmour commented 3 years ago

Looks good to me! @stephanieyurchak can you confirm one last time?

stephanieyurchak commented 3 years ago

Confirmed