bcgov / wps

Wildfire Predictive Services to support decision making in prevention, preparedness, response and recovery
Apache License 2.0
39 stars 9 forks source link

HFI Calculator: UI Feedback - demonstrate when each planning area of a Fire Centre is 'ready' (fuel and fire starts adjusted by ZWCO) #1859

Closed tessmgood closed 2 years ago

tessmgood commented 2 years ago

As a RWCO or Plans stakeholder I want crystal clarity on the status of the HFI Calculator on prep morning So That in the context of fast-paced decision making I know if I'm looking at 'good' (ZWCO decisions) or 'bad' (default) data without having to manually communicate with ZWCOs and distract them from their task

Additional Context

Ready for Review Toggle: Permissions DECISION_ Ready for Review Toggle_ Editing.png

Ready for Review Toggle: No permissions DECISION_ Ready for Review Toggle_ Read only.png

Acceptance Criteria Given I an using the HFI Calc with Permissions to edit Planning Area (R/ZWCO):

Given I an using the HFI Calc withOUT Permissions to edit Planning Area (read only or other role):

Definition of Done

TMI

dthicks commented 2 years ago

I think the example in figma is the best way to go. The check mark will show other users that the zone is complete

Sybrand commented 2 years ago

Please add your planning poker estimate with ZenHub @andrea-williams

conbrad commented 2 years ago

@Sybrand I have some questions on this ticket regarding the backend. I guess these ready states need to be persisted as part of a hfi_request, correct? That way switching prep periods would display the ready states associated with the respective hfi_request (hfi_request being the table name, for lack of better terminology).

Assuming that's correct, would it make sense to just alter that table with a ready flag column? It would probably be easiest to have it as a json column so that we can store the ready state for the arbitrary number of planning areas for a given fire centre.

Sybrand commented 2 years ago

@conbrad altering the json (hfi_request) is probably the way to go yes. The database currently doesn't have any understanding of planning areas - or much else. Wouldn't want to split the ready state between database and json.

So you'd be editing HFIResultRequest - adding another list maybe - planning_area_ready : Dict[int, bool] ? and a boolean like fire_centre_read: bool?

conbrad commented 2 years ago

Makes sense. Yes that's probably the best/easiest option. Thanks!