bcgov / wps

Wildfire Predictive Services to support decision making in prevention, preparedness, response and recovery
Apache License 2.0
39 stars 9 forks source link

HFI Calculator: Permission status #1976

Closed tessmgood closed 2 years ago

tessmgood commented 2 years ago

As a Plans / RWCO / ZWCO / Forecaster I want a logout button in the HFI interface So That I can ensure I am logged in as the correct IDIR with permissions to do my work AND so I can log out of the 'general' Plans/R/ZWCO account and get back to my personal IDIR when I am done

Additional Context

Acceptance Criteria Permissions:

Definition of Done

Sybrand commented 2 years ago

Please add your planning poker estimate with ZenHub @andrea-williams

conbrad commented 2 years ago

AC and "As an X" story statement seem orthogonal. AC do not include cases for personal idir accounts with permissions so it also seems incomplete. I'm going to treat the "As an X" story description as the AC of this ticket until there is more clarity.

conbrad commented 2 years ago

Investigating further, it seems like the "As an X" story description is duplicated with the one in this ticket: https://app.zenhub.com/workspaces/wildfire-predictive-services-5e321393e038fba5bbe203b8/issues/bcgov/wps/1956

tessmgood commented 2 years ago

@conbrad my understanding is personal IDIR's won't have permissions - I don't see any in the permissions spreadsheet. Which use cases/users are you aware of? re: incomplete AC. I'm not sure what you mean by orthogonal. We quickly split up all the permissions criteria from 1 to 3 tickets in planning ceremony, why you're seeing story overlaps. Happy to help clarify anything this morning.

conbrad commented 2 years ago

I'm not sure what you mean by orthogonal. Ticket description at top writes about a logout button, AC talks about permissions my understanding is personal IDIR's won't have permissions - I don't see any in the permissions spreadsheet. Which use cases/users are you aware of? re: incomplete AC. Correct. I thought I read AC as only talking about personal IDIRs without permissions and not IDIRs in general but it states both so my eyes deceived me.

Anyway, I wrote what I understand is the minimal set of AC for achieving the goals of this ticket in the PR: https://github.com/bcgov/wps/pull/1995