Use built in API testing client for FastAPI endpoint tests

bcgov / wps

Wildfire Predictive Services to support decision making in prevention, preparedness, response and recovery

Apache License 2.0

38 stars 7 forks source link

Use built in API testing client for FastAPI endpoint tests #2003

Open conbrad opened 2 years ago

conbrad commented 2 years ago

Describe the task Current Gherkin setup is error prone and time consuming. Use the built in api testing functionality that already exist in Fast API: https://fastapi.tiangolo.com/tutorial/testing/#extended-testing-file

Acceptance Criteria

[ ] Any new API endpoint tests are written using the documented testing facilities in FastAPI

Additional context

https://fastapi.tiangolo.com/tutorial/testing/#extended-testing-file

Sybrand commented 2 years ago

This is more a decision than a task I think - unless you're proposing re-writing all the Gherkin stuff? Also the Gherkin stuff is using the Fast API client already. I'm cool moving forward not using gherkin, it's a pain, and I'm ready for a new kind of pain.

conbrad commented 2 years ago

I'll rewrite the gherkin tests if that's what it takes to stop using them...

Sybrand commented 2 years ago

:) I feel your pain. I think we should try a different approach on the Fire Behaviour Advisory 1st.

conbrad commented 2 years ago

Sounds good, the AC I wrote is for "any new tests" so it's not suggesting a cumbersome big-bang change.