substitute_variables(strict = FALSE) no longer working that well

bcgov / wqbc

An R package for water quality thresholds and index calculation for British Columbia

http://bcgov.github.io/wqbc/

Apache License 2.0

19 stars 9 forks source link

substitute_variables(strict = FALSE) no longer working that well #151

Closed joethorley closed 3 years ago

joethorley commented 4 years ago

With the increase in the number of variables the strict = FALSE setting of substitute variables is no longer performing that well.

substitute_variables(c("Iron Total", "Iron Dissolved", "Aluminum"), strict = FALSE)
[1] NA                                      "Dissolved Solids (Filterable Residue)" NA

Should we deprecate the strict argument?

joethorley commented 4 years ago

What do you think @HeatherGranger?

HeatherGranger commented 4 years ago

Agree @joethorley. I believe this is what is behind the 'Strict matching' argument in the tidy tab in shinyrems and noticed when it was not checked (strict = FALSE) i'm assuming, the data would disappear. Given the number of variables, knowing exactly what the user wants to view makes sense. Let's remove the argument.