search

bcgov / wqbc

An R package for water quality thresholds and index calculation for British Columbia
http://bcgov.github.io/wqbc/
Apache License 2.0
20 stars 9 forks source link

ncen table edit #170

Closed HeatherGranger closed 1 year ago

HeatherGranger commented 1 year ago

Suggestion for improvement and clarification:

I am wondering about modifying the ncen column so that is shows the number of censored observations regardless of whether the user opts for the ml summary stats estimation. Right now when you use summarise_wqdata(x, censored=FALSE) the ncen automatically defaults to 0. I think it makes more sense to still provide the ncen as the numbers of observations where the Value <= Detection Limit.

joethorley commented 1 year ago

@HeatherGranger - did you mean to close this issue?

HeatherGranger commented 1 year ago

@joethorley Yes - I added it to shinyrems repo, I think it fits there better for potential future opportunity.