search

bcgov / wqbc

An R package for water quality thresholds and index calculation for British Columbia
http://bcgov.github.io/wqbc/
Apache License 2.0
20 stars 9 forks source link

parameter 'color true' unit #77

Closed HeatherGranger closed 7 years ago

HeatherGranger commented 7 years ago

Low priority item

EMS parameter 'color true' has units of Col.unit which get changed to CU during clean_wqdata. The actual units should be TCU (total colour units). This may be an EMS issue if it's annoying to change in the clean_wqdata function.

ateucher commented 7 years ago

Working in the col-units branch - I changed everything to "Col.units" as that is what is in EMS... Where do you see/use "TCU"?

HeatherGranger commented 7 years ago

Col.units def works as that is what EMS says.

TCU is just the current units that true colour are described in. So not in EMS, just an 'expert piece of info' I guess?!

ateucher commented 7 years ago

Gotcha, thanks. I think I'll leave it as Col.units as that is what will be coming from EMS.

If you get a chance, can you try it out? You can install with:

devtools::install_github("bcgov/wqbc", ref = "col-units")

stephhazlitt commented 7 years ago

Maintenance

HeatherGranger commented 7 years ago

@ateucher Successful trial of Col.unit !