search

bcgov / wqg_data

Refining the WQG list
GNU General Public License v3.0
3 stars 3 forks source link

Strip Total and Dissolved into new column #50

Closed sebdalgarno closed 4 years ago

sebdalgarno commented 4 years ago

if doesn't say explicitly, assume 'Total'... what should the new column name be?

joethorley commented 4 years ago

I don't think we should strip the columns into Total and Dissolved because it doesn't apply in all situations.

sebdalgarno commented 4 years ago

FYI the initial comment from Angeline -

Some substances (aluminum, cadmium, copper, iron, organic carbon and sulphate) have both dissolved and total forms. We think it may be confusing for the user as they won't know for example, that the guideline for dissolved sulphate is only for livestock and may assume that there are no other guidelines for sulphate. I suggest that we strip off the "total" and "dissolved" labels from the substance and put this in a separate column. If the substance has no label, then we can assume it is total. Within the table then, it will need to be specified if the WQG value is for total or dissolved.

joethorley commented 4 years ago

I think this only works if everything that is not Total or Dissolved can be labelled Total.

sebdalgarno commented 4 years ago

done