search

bcgov / wqg_data

Refining the WQG list
GNU General Public License v3.0
3 stars 3 forks source link

Hardness Total and Hardness Dissolved #54

Closed sebdalgarno closed 4 years ago

sebdalgarno commented 4 years ago

In cases where it doesn't make a difference if user provides Hardness Total or Hardness Dissolved, we should just include Hardness Total in the Conditions.

this will be a more robust solution than trying to hack around it in the app.

atillmanns commented 4 years ago

@sebdalgarno - when calculating the WQG, the user may use dissolved or total hardness. For the WQG user interface, it's not really a concern. We just need one box for hardness. For the WQG analysis app, the user may need to pull either total or dissolved hardness from EMS so the app needs to allow them to do both.

sebdalgarno commented 4 years ago

OK thanks for clarification! I will leave as is in the spreadsheet and work around it in the WQG user interface. I'll close this now because there is a similar issue open in the shinywqg repository: https://github.com/poissonconsulting/shinywqg/issues/29