search

bcgov / wqg_data

Refining the WQG list
GNU General Public License v3.0
3 stars 3 forks source link

Statistic is differentiating guidelines - geomean #68

Closed sebdalgarno closed 4 years ago

sebdalgarno commented 4 years ago

See UniqueID 385/386 and 388/389 Statistic (geomean vs. mean) appears to be the only thing differentiating Guidelines (considering Variable, Use, Media, Type, PredictedEffectLevel, Direction).

It can be differentiated by Days/Samples but the app currently does not allow user to filter by Days/Samples.

If we want to remove Statistic from user selection in App, do we need to adjust the Type of these to differentiate them? (e.g. 'Primary Contact - long-term' for the geomean)

thoughts @atillmanns ?

sebdalgarno commented 4 years ago

this could also be resolved by e.g. adding 'geomean' and 'mean' to each respective LimitNotes

sebdalgarno commented 4 years ago

FYI I've confirmed that these are the only remaining cases where Statistic is the only thing differentiating the Limits

atillmanns commented 4 years ago

For 385/386, there are two limits, one for max and one for geomean, so need both. The same is for 388/389. @sebdalgarno does this make sense or maybe I'm missing something?

HeatherGranger commented 4 years ago

Agree with angeline. If statistic column is removed, then type could be updated to Primary Contact - Single Sample Max and Primary Contact - Geometric Mean

sebdalgarno commented 4 years ago

yes I agree for sure that both limits should remain. Also to be clear, I'm not suggesting that we remove Statistic column from spreadsheet. It's just that if we want to remove Statistic from user filter options and report display in the Shiny app then we need some way to inform the user why they are getting two different limits...perhaps in these cases we could add the statistic to the LimitNotes

joethorley commented 4 years ago

I think it makes more sense to code as Primary Contact - Short-term acute and Primary Contact - Long-term chronic. Thoughts?

HeatherGranger commented 4 years ago

Either adding to the LimitNotes or updating the Type makes sense to me. The wording for Recreation guidelines are based on human health, not aquatic life terminology, so short term acute and long term chronic are not correct. The wording here is what they're called in the guideline document: Primary Contact - Single Sample Max and Primary Contact - Geometric Mean

joethorley commented 4 years ago

OK lets go with the guideline terminology.

sebdalgarno commented 4 years ago

OK great I'll make those changes