search

bcgov / wqg_data

Refining the WQG list
GNU General Public License v3.0
3 stars 3 forks source link

EMS code convention #82

Closed sebdalgarno closed 4 years ago

sebdalgarno commented 4 years ago

In the wqbc::limits and wqbc::codes table, the convention for an EMS code consisting of EMS_ followed by two letters is "EMS_X__X". However in the new guidelines the convention is "EMSX-X" (with hyphen instead of underscore)

The cases include:

Is there a reason for the switch?

joethorley commented 4 years ago

No this is an error (I guess using sub instead of sub) they should all be _.

sebdalgarno commented 4 years ago

OK great - should I make that change on wqg_data now?

joethorley commented 4 years ago

Yes please

sebdalgarno commented 4 years ago

done - note it also affected Vanadium Total