Closed sebdalgarno closed 4 years ago
1. The following limits have different values for Term column:
2. There is no Chloride Total (EMS_0104) in new guidelines (only Chloride Dissolved (EMS_1104)
3. There is 'Chlorine Residual: Total' (EMS_1016) in wqbc limits and 'Chlorine Total' (EMSCL2) in new guidelines...however there is no EMS_1016 in new guidelines or EMSCL2 in wqbc limits
4. The following are in the wqbc limits but missing from new guidelines:
5. Copper Total (EMS_CU_T) is in wqbc limits but in new guidelines sheet it has Media of "Sediment" - it appears to be the only guideline with Media 'Sediment' that also exists in the wqbc limits table. Is this a mistake? Should there also be a Media = 'Water' limit for Copper Total?
6. Copper Total (EMS_CU_T) - in wqbc limits table there are limits for Copper Total with Term = "Long". In the new guidelines there are no limits for Copper Total - Aquatic Life Freshwater with Term = "Long"
Note: some sediment samples have a Days/Samples of 1 but they have a term of "long" so the rule quoted below won't work for sediments.
I have filtered out any limits from the new guidelines spreadsheet with Use of 'Freshwater Life' (e.g. 'Aquatic Life - Freshwater') and Media of "Water" and Direction of "Upper Limit". I have recreated the Term column where Days/Samples of 1 is "short" and Days/Samples of 30/5 is "long".
Note: some sediment samples have a Days/Samples of 1 but they have a term of "long" so the rule quoted below won't work for sediments.
I have filtered out any limits from the new guidelines spreadsheet with Use of 'Freshwater Life' (e.g. 'Aquatic Life - Freshwater') and Media of "Water" and Direction of "Upper Limit". I have recreated the Term column where Days/Samples of 1 is "short" and Days/Samples of 30/5 is "long".
OK great - I will assume the Copper Total Term is short then since that is what it is in wqbc limits
the above comments resolve issues 1 and 6
2 - chloride can only be dissolved, it is an ion. So new table is correct.
3 - should be Chlorine Residual: Total' (EMS_1016) - corrected in spreadsheet
Nitrogen Dissolved (EMS_1114) - there is no freshwater - AL WQG for nitrogen dissolved Nitrogen Total (EMS_0114) - there is no freshwater - AL WQG for nitrogen total
Phosphorous Dissolved (EMS_P__D) - there is no freshwater AL - WQG for dissolved phosphorus
Nitrogen Dissolved (EMS_1114) - there is no freshwater - AL WQG for nitrogen dissolved Nitrogen Total (EMS_0114) - there is no freshwater - AL WQG for nitrogen total
- the only nitrogen guidelines are for nitrate, nitrite and ammonia
Phosphorous Dissolved (EMS_P__D) - there is no freshwater AL - WQG for dissolved phosphorus
Thanks for confirmation - they will not appear in the new wqbc limits table
- The freshwater AL WQG was updated earlier this year. There is no longer a freshwater AL WQG for total copper, it is now just for dissolved copper and it needs to be calculated using the BLM software. The WQGs for other values should be the same.
OK thanks - Copper Total will not appear in the new wqbc limits table
From slack - final issue resolved
I need to recreate the wqbc::limits table from the new guidelines spreadsheet for the ShinyRems app and for use in wqbc. The wqbc::limits table has the following columns: Variable, Use (all 'Freshwater Life'), Term, Condition, UpperLimit, and Units.
I have filtered out any limits from the new guidelines spreadsheet with Use of 'Freshwater Life' (e.g. 'Aquatic Life - Freshwater') and Media of "Water" and Direction of "Upper Limit". I have recreated the Term column where Days/Samples of 1 is "short" and Days/Samples of 30/5 is "long".
I think the table should have all of the records from the old limits table (for backward compatibility) as well as any new limits that are Freshwater Life (Use) and Water (Media) and Upper Limit (Direction). It is fine for the limits to have new Conditions or UpperLimits, but they should have the same EMS_Code and Term.
I will add the issues I have come across in the comments below and number them so we can easily reference them: