bcgov / wqg_data

Refining the WQG list
GNU General Public License v3.0
3 stars 3 forks source link

Units discrepancy wqbc limits vs new guidelines #84

Closed sebdalgarno closed 4 years ago

sebdalgarno commented 4 years ago

Three Variables have different units in the new guidelines

joethorley commented 4 years ago

I think we should move the N from Units to the Component column as mg/L N is not a recognized unit but we should confirm with @atillmanns and @HeatherGranger

HeatherGranger commented 4 years ago

I can answer for nitrate - I think this could work. What do you think @atillmanns

atillmanns commented 4 years ago

Right - I suppose throwing the "N" in the units column will prevent the ability to easily convert between units. The phrases, "Total" and "Dissolved" have typically been used to refer to whether or not the substance was found in a whole water sample or whether or not it had been filtered first. This is the way we define it in our technical documents so I don't want to confuse people by adding other information in this column. I think it makes most sense to add something to the limit notes. We could add back in, "reported as N" to the limit notes.

joethorley commented 4 years ago

I fear it will get lost in the limit notes and will be hard for a machine to parse.

One option is to separate it from Total and Dissolved using a - ie Dissolved - Nitrogen.

Another option is to add a column called Subcomponent and have it in here?

sebdalgarno commented 4 years ago

"reported as N" makes sense I think. In fact some already have this in the ConditionNotes:

Screen Shot 2020-03-18 at 8 32 32 AM

If we are to move to LimitNotes, then we should move these ConditionNotes to the LimitNotes as well I think

atillmanns commented 4 years ago

I don't understand why we need a whole new column? Why cannot this information be included in the limit notes?

HeatherGranger commented 4 years ago

I think adding 'reported as N' makes sense in the LimitNotes best I think. The unit is more specific to the LimitNotes rather than the ConditionNotes. I don't think adding another column would necessarily clarify things for a user.

sebdalgarno commented 4 years ago

OK I will add 'reported as N' to LimitNotes and move from ConditionNotes to LimitNotes where present

atillmanns commented 4 years ago

@sebdalgarno - thanks! And for barium, mg/L is correct.

sebdalgarno commented 4 years ago

done