search

bcgov / wqg_data

Refining the WQG list
GNU General Public License v3.0
3 stars 3 forks source link

EMS_M050 duplicates #86

Closed sebdalgarno closed 4 years ago

sebdalgarno commented 4 years ago
Screen Shot 2020-03-17 at 6 05 10 PM

These all have the same EMS code but different Variable names and different Limits (unrelated to Condition)

atillmanns commented 4 years ago

Yes, that's the only code we have for monochlorophenols so these are not really duplicates. It is a code that applies to a group of substances.

joethorley commented 4 years ago

I think we should either 1) remove the EMS_Code because other than the limits (and variable names which are not reliable to tell things apart) they are confusing duplicates. 2) Distinguish them in a Subcomponent column (see #84) or in the LimitsNotes

atillmanns commented 4 years ago

I don't agree that these are confusing duplicates. The variables are all monochlorophenols (EMS_M050) and the variable allows them to be distinguished as it clearly states the location of the chlorine atom. Agreed that ideally there would be a unique EMS code for each monochlorophenol, but this is not the case in EMS. The user of the water quality analysis app will have to know which monochlorophenol they are dealing with but if the data is stored in EMS, it will be stored under this code.

sebdalgarno commented 4 years ago

OK we will leave this - they will all be removed from wqbc limits table