bcgov / zeva

Zero Emission Vehicles Act
Apache License 2.0
5 stars 13 forks source link

ZEVA - Model Year Report Rounding Error #2129

Closed shayjeff closed 9 months ago

shayjeff commented 10 months ago

Describe the Bug There is a rounding error in the ZEVA system affecting the "Unspecified ZEV Class Credit Reduction" in the Model Year Report (screen capture below).

Expected Behaviour The system should round up correctly according to standard rounding rules.

Actual Behaviour The rounding in the "Unspecified ZEV Class Credit Reduction" is not functioning correctly. It seems the rounding mechanism may have changed, possibly during a recent ZEVA update or launch.

Implications This rounding error may impact the accuracy of credit calculations and reporting for Model Year Report.

Steps To Reproduce Steps to reproduce the behavior: User/Role:

  1. Go to ZEVA system.
  2. Navigate to Compliance Reporting, select the 2022 MY Report
  3. Check the Assessment Tab and "Unspecified ZEV Class Credit Reduction" section.
  4. Note the discrepancy in rounding.

Development Checklist (1) Get the production data into your local database, and test it; it's probably a frontend issue.

Notes: If you have to use production data, please contact the PO for the supplier information.

Rounding Error Capture.JPG
kcabhar commented 9 months ago

Hey team! Please add your planning poker estimate with Zenhub @tim738745 @emi-hi

shayjeff commented 9 months ago

The "B" reductions didn't update on the assessment page.

shayjeff commented 9 months ago

This issue was for a specific supplier. Testing have been completed by myself (PO) and the PA who reported it.