bcgov / zeva

Zero Emission Vehicles Act
Apache License 2.0
5 stars 13 forks source link

CTHUB - Data Upload Errors Description #2208

Open Lalita-Lala opened 3 months ago

Lalita-Lala commented 3 months ago

Describe the task When uploading data, a pop-up will display the number of errors and warnings. All errors must be fixed before proceeding with the upload. The errors should have a detailed description, which includes: Error name, Expected value, Row with errors It is critical that the error name and the expected value are accurate and descriptive. We need to ensure that they are displayed with the correct set of information.

Purpose and benefit to user This ensures that the user receives accurate information about all possible errors in their file and can correctly address them, fixing their data before re-uploading.

Acceptance Criteria

Additional information The data table may have 12 columns. Each column can have 1 or 2 errors, but no more than 2. The column names, possible error names, and expected values are listed below:

katerinkus commented 1 month ago

I tested this ticket using the ARC dataset. Thank you for your work, Julian, this ticket has a lot of moving parts. I found that most errors worked but I ran into issues with numeric and datetime stuff and some strange messages that may have been there in the earlier CTHub versions. @JulianForeman @shayjeff, I'll leave it up to you to decide whether those fixes should be a new card or whether they should be done as part of this card.

Notes on errors

JulianForeman commented 1 week ago

I have put a PR up addressing the duplicated formatting, regions info, and upload alert. The other 2 after speaking with Shaylene we decided should move to their own fix card; being the odd crash when a type is wrong and the wrong row number being displayed.

katerinkus commented 4 days ago

@JulianForeman thank you for your work!

The other 2 after speaking with Shaylene we decided should move to their own fix card; being the odd crash when a type is wrong and the wrong row number being displayed.

@shayjeff I made the following two cards and put them in new issues:

  1. Created a card for numeric and datetime errors: CTHUB - Create numeric and datetime errors #415
  2. Created a card for row issues here: Missing error row number is off by one #416