Open Lalita-Lala opened 3 months ago
I tested this ticket using the ARC dataset. Thank you for your work, Julian, this ticket has a lot of moving parts. I found that most errors worked but I ran into issues with numeric and datetime stuff and some strange messages that may have been there in the earlier CTHub versions. @JulianForeman @shayjeff, I'll leave it up to you to decide whether those fixes should be a new card or whether they should be done as part of this card.
Error Name: Invalid Region
Expected value: The following rows have an invalid region
Rows with error: 2
There was an issue uploading the file
. I've also noticed that the business area did not identify correct columns to be numeric and datetime. Start Date should be datetime and Funds Committed should be numeric. I'll make a ticket for that. Apologies for not noticing it the first timeThere was an issue uploading the file
. I have put a PR up addressing the duplicated formatting, regions info, and upload alert. The other 2 after speaking with Shaylene we decided should move to their own fix card; being the odd crash when a type is wrong and the wrong row number being displayed.
@JulianForeman thank you for your work!
[x] Multiple categories (e.g. Economic Region). It works but the message does not list possible categories.
Works now! 🥳
[x] Formatting. Formatting is a bit off. Specifically, the message is repeated twice. Seems like the old formatting and the new mock-up formatting (with bullets are combined):
Looks right now.
[x] Upload alert ("We encountered...") is gone.
The other 2 after speaking with Shaylene we decided should move to their own fix card; being the odd crash when a type is wrong and the wrong row number being displayed.
@shayjeff I made the following two cards and put them in new issues:
Describe the task When uploading data, a pop-up will display the number of errors and warnings. All errors must be fixed before proceeding with the upload. The errors should have a detailed description, which includes: Error name, Expected value, Row with errors It is critical that the error name and the expected value are accurate and descriptive. We need to ensure that they are displayed with the correct set of information.
Purpose and benefit to user This ensures that the user receives accurate information about all possible errors in their file and can correctly address them, fixing their data before re-uploading.
Acceptance Criteria
Additional information The data table may have 12 columns. Each column can have 1 or 2 errors, but no more than 2. The column names, possible error names, and expected values are listed below:
Column: Approvals (1) Error name: Complete, On Hold - is not in the list of expected values Expected value: Approved, Approved Fraudulent (2) Error name: Missing Value Expected value: Cells in this column cannot be blank
Column: Date (1) Error name: Not in datetime format Expected value: YYYY-MM-DD (2) Error name: Missing Value Expected value: Cells in this column cannot be blank
Column: Max Incentive Amount Requested Error name: Not numeric Expected value: Numeric
Column: Category (1) Error name: Value not in the list Expected value: Forklift, Low Speed, Motorcycle, Medium & Heavy Duty, Airport & Port Specialty Vehicle, Cargo E-Bike, Utility Vehicle (2) Error name: Missing Value Expected value: Cells in this column cannot be blank
Column: Fleet/Individuals (1) Error name: Value not in the list Expected value: Fleet, Individual (2) Error name: Missing Value Expected value: Cells in this column cannot be blank
Column: Incentive Paid (1) Error name: Not numeric Expected value: Numeric (2) Error name: Missing Value Expected value: Cells in this column cannot be blank
Column: Rebate adjustment (discount) Error name: Value not in the list Expected value: Yes
Column: Total Purchase Price (pre-tax) Error name: Not numeric Expected value: Numeric
Column: Manufacturer Error name: Missing Value Expected value: Cells in this column cannot be blank
Column: Model Error name: Missing Value Expected value: Cells in this column cannot be blank
Column: City Error name: Missing Value Expected value: Cells in this column cannot be blank
Column: Class Error name: Value not in the list Expected value: 2b, 3, 4, 5, 6, 7, 8