bcgov / zeva

Zero Emission Vehicles Act
Apache License 2.0
5 stars 13 forks source link

ZEVA: Fix Rounding Error Between Credit Transaction Line Items and Detailed Credit Balance #2216

Closed shayjeff closed 2 months ago

shayjeff commented 3 months ago

Describe the task
Identify and correct a rounding error on the credit transactions page. The issue involves discrepancies between the sum of Credit Transaction line items and the Detailed Credit Balance for multiple suppliers.

Purpose
This task is important for maintaining accurate credit balance data on the credit transactions page. Correcting the rounding error will improve data integrity and prevent discrepancies that could affect credit balance and compliance reporting.

Acceptance Criteria

Additional context

The BA had sampled a handful of suppliers and all of them have a rounding issue. Please reach out to the PO for the list if needed.

shayjeff commented 3 months ago

Notes from the business area: Rounding issue – All Suppliers (including Tesla) Credit Transaction Page -Under Credit Transactions: i. The credit column when summed result with a rounding error of (0.01). ii. This can affect both credit A or B columns depending on how the supplier paid their obligation

katerinkus commented 2 months ago

The fix works for current calculations but not for numbers that are already stored. PO to check with the business area about the plan.