search

bcgsc / NanoSim

Nanopore sequence read simulator
Other
217 stars 51 forks source link

fix read headers in metagenome simulation #167

Closed LokiLuciferase closed 2 years ago

LokiLuciferase commented 2 years ago

Hi,

When running metagenome simulations while outputting fastq files, with the most recent version of NanoSim 3.1, I found that read headers are empty (consisting only of the initial @ but no other information). It seems like right before finalization of a read, the header is set to the empty string once again. This PR fixes this.

I have attached a directory (test_case_nanosim.tar.gz) containing all required files for building a docker container which replicates the issue, and demonstrates the fix described in this PR, which can be built and executed by running docker build ..

kmnip commented 2 years ago

Good catch!

kmnip commented 2 years ago

@SaberHQ , I tested the code in a test simulation and the read name looks good. Thanks @LokiLuciferase for your PR!