bcgsc / NanoSim

Nanopore sequence read simulator
Other
217 stars 51 forks source link

Merge meta #96

Closed cheny19 closed 3 years ago

SaberHQ commented 3 years ago

Dear Chen, Thanks for the great work on this pull request. I have several suggestions and comments before you can merge this branch. Please let me know if you have any questions.

I tested the "metagenome" mode with different scenarios and parameter sets and everything worked well, except for one error run. The simulation code crashed when I asked for "perfect" reads. It produced "local variable referenced before assignment" runtime error. Please take a look into this before merging this branch into master.

Below, you can find some comments as well.

cheny19 commented 3 years ago

Hi @SaberHQ , thanks for such thorough review. I have merged the branch and will revise the code and README accordingly.