search

bcgsc / btl_bloomfilter

The BTL C/C++ Common bloom filters for bioinformatics projects, as well as any APIs created for other programming languages.
GNU General Public License v3.0
18 stars 4 forks source link

Counting bloom filter adjustments #19

Closed jwcodee closed 5 years ago

jwcodee commented 5 years ago

This pull request includes minor adjustments suggested by Shaun. The only thing that is missing is assert_good which is from another repo. Do you want me to vendor that from abyss? or just leave the assert statements as is?

sjackman commented 5 years ago

The only thing that is missing is assert_good which is from another repo. Do you want me to vendor that from abyss?

Yes, please do copy it in. It's a useful function. It gives a much better error message. You can do that in a separate PR.

jwcodee commented 5 years ago

When I removed using namespace std; the code could still compile, so I read through the code and added std:: to classes I know that requires the namespace. I'm not sure if I caught everything though. I have ran and executed the code and it seems to be fine.

sjackman commented 5 years ago

Check that there's no using namespace std; in other header files in the code base.

sjackman commented 5 years ago

Check that there's no using namespace std; in other header files in the code base.

If there are, you could address that issue in a separate PR.

sjackman commented 5 years ago

Thank you!