search

bcgsc / btl_bloomfilter

The BTL C/C++ Common bloom filters for bioinformatics projects, as well as any APIs created for other programming languages.
GNU General Public License v3.0
18 stars 4 forks source link

Clang tidy #20

Open jwcodee opened 5 years ago

jwcodee commented 5 years ago

The error from CI is only from clang-tidy.

sjackman commented 5 years ago

clang-tidy should ignore the fileTests/Unit/catch.hpp because it's vendored. You could move it to a subdirectory of vendor/.

sjackman commented 5 years ago

This PR must pass CI before merging. One way to do that is to make the necessary fixes to silence the clang-tidy errors. Another option is to ignore the failure of the clang-tidy errors in the Makefile. The former solution is preferable.

jwcodee commented 5 years ago

clang-tidy should ignore the fileTests/Unit/catch.hpp because it's vendored. You could move it to a subdirectory of vendor/.

I'll do this in a separate PR since I'll have to change the regex for the clang-format too. I didn't catch was vendor library too.

sjackman commented 5 years ago

Is this PR the next to be merged?

jwcodee commented 5 years ago

hmm I don't know how much work it will take to clear all the errors. My original plan was to make the 1.2.0 release then do the clang-tidy work.

sjackman commented 5 years ago

That sounds good.