1.2.0 - Githubissues

bcgsc / btl_bloomfilter

The BTL C/C++ Common bloom filters for bioinformatics projects, as well as any APIs created for other programming languages.

GNU General Public License v3.0

18 stars 4 forks source link

1.2.0 #26

Closed jwcodee closed 5 years ago

jwcodee commented 5 years ago

This PR contains misc changes to master before 1.2.0 release. Changes include:

Updating README
Moving catch.hpp to vendor and undo white space changes
add vendor to include paths

With regards to "add vendor to include paths", we think that it makes more sense for the user to just do -I/path/btl_bloomfilter/ instead of -I/path/btl_bloomfilter/ -I/path/btl_bloomfilter/vendor

Once there are no more changes, I will do a final commit where I change configure.ac

jwcodee commented 5 years ago

So I realized the AdHoc tests weren't running so I added them back to check. I also resolved errors as a results of using an older in the AdHoc tests. If everything is fine, my next commit will be the configure.ac change

jwcodee commented 5 years ago

@JustinChu @sjackman

Under "acknowledgements" should "rolling hash implementation by Hamid Mohamadi" be " nthash implementation by Hamid Mohamadi" instead and then a link to his repo or nthash containing a hyperlink?

JustinChu commented 5 years ago

Yeah, and adding a hyperlink makes a lot of sense.

jwcodee commented 5 years ago

Keeping this branch for now