search

bcgsc / btl_bloomfilter

The BTL C/C++ Common bloom filters for bioinformatics projects, as well as any APIs created for other programming languages.
GNU General Public License v3.0
18 stars 4 forks source link

swig interface declared that is not defined #4

Closed douglasgscofield closed 6 years ago

douglasgscofield commented 6 years ago

swig/BloomFilter.i is defining an interface to insert() and contains() methods accepting const char* but BloomFilter.hpp doesn't contain those definitions, only ones involving size_t reference or pointer. The tests are expecting to do thinks like insert("ATCG").

JustinChu commented 6 years ago

Thanks for the report. It seems that in my attempt to decouple parts of the code (to make the hashing generalizable to more than just nucleotides k-mers) I broke the swig module. I'll fix it soon, what I may do is create a subclass that expect k-mer sequences.

JustinChu commented 6 years ago

Okay I've pushed a fix: f02a7d7cb9b238ec1b429baa092229e5a84fe0ed.

I've run the internal tests, let me know if you have any problems, Douglas.

Thanks.