search

bcgsc / btllib

Bioinformatics Technology Lab common code library
Other
23 stars 5 forks source link

Fix wrappers #82

Closed parham-k closed 1 year ago

parham-k commented 1 year ago

The ordering of the include statements in wrappers/python/btllib.i is important for successfully compiling and using the wrappers. Previously, we regenerated btllib.i by listing the files in the include directory with find, which lead to inconsistent orderings and potential bugs (like the one in SeqReader).

Changes:

This fixes the SeqReader bug seen in v.1.5.0. @lcoombe, can you please confirm that LongStitch or any other project depending on btllib now works with this branch?

parham-k commented 1 year ago

Yes, this should prevent it. I think it'll also make debugging easier if any other issues happen. The best thing to do now is to add more wrapper tests.

lcoombe commented 1 year ago

Awesome! Yes, I can help with adding more wrapper tests (in a future PR) - particularly having the indexlr wrapper in there too would be good (since I use that in ntLink as well)