search

bcgsc / btllib

Bioinformatics Technology Lab common code library
Other
23 stars 5 forks source link

Add python wrapper tests for Indexlr and RandomSequenceGenerator #83

Closed lcoombe closed 1 year ago

lcoombe commented 1 year ago

Adding a couple more tests for the python wrappers

vlad0x00 commented 1 year ago

Just a stylistic remark, but my suggestion would be renaming RandomSequenceGenerator to something shorter (and equally understandable) like RandSeqGenerator, RandomSeqGen, or RandomSeqGenerator. The full name is a tad unwiedly.

lcoombe commented 1 year ago

Thanks for that suggestion Vlad - makes sense! We could look into doing that in a separate PR maybe?

parham-k commented 1 year ago

I'll rename the class to RandomSeqGen in another PR.