search

bcgsc / btllib

Bioinformatics Technology Lab common code library
Other
23 stars 5 forks source link

Fix mibf wrapper #87

Closed parham-k closed 1 year ago

parham-k commented 1 year ago

Fix for multi-index Bloom filter's Python wrappers

MurathanGoktas commented 1 year ago

Nice work. I have already been doing progress on this issue and currently have an exhaustive testing script at wrapper_tests branch. You can test your wrapper modifications with that testing script.

parham-k commented 1 year ago

Sorry I didn't notice you had so much progress on this @MurathanGoktas. @jwcodee and I are working on the aahash branch, and regenerating the wrappers in master causes the issue in #86, which prevents btllib from compiling. When do you think we can merge your wrapper_tests branch into master if this is fixed there?

MurathanGoktas commented 1 year ago

No worries @parham-k. For mi-bf it is already tested and working at wrapper_tests. My intention was to create PR when I made the tests for other classes available too. However if it is critical we can already merge wrapper_tests or @jwcodee can use the current latest commit from that branch.

parham-k commented 1 year ago

Addressed in #89