search

bcgsc / goldrush

Linear-time de novo Long Read Assembler
GNU General Public License v3.0
35 stars 2 forks source link

gr-path: add log for number of valid reads visited when making a silver path #132

Closed jwcodee closed 7 months ago

jwcodee commented 7 months ago

This pull request adds log information for how many valid reads were visited after generating x silver paths

lcoombe commented 7 months ago

Thinking about these options that we're adding when 'verbose' specified - but currently we don't have an easy way to enable that verbosity via the makefile, right? What do you think about making --verbose default? None of those messages are too much, so could just be more informative for users (and us)

jwcodee commented 7 months ago

https://github.com/bcgsc/goldrush/blob/d39cb4cf620d9042a28b672dc81d3a2c51a2c467/goldrush_path/goldrush_path.cpp#L793 @lcoombe sure, let's enable verbose by default While we are on that note, should I add this to verbose or debug. It's there to show that goldrush is still running, but I dont think it's that useful from a verbose perspective,

lcoombe commented 7 months ago

I think we keep that as default/verbose? I like seeing it to see that GoldRush is progressing through the reads?

jwcodee commented 7 months ago

Cool, Ill keep it as default then and ill push the verbose change soon too.