bcgsc / ntEdit

✏️ Genome assembly polishing & SNV detection
GNU General Public License v3.0
64 stars 9 forks source link

definition of solid with a CBF #47

Closed warrenlr closed 8 months ago

warrenlr commented 9 months ago

https://github.com/bcgsc/ntEdit/blob/ac2c5607c5468af875912a00c0c56d84630d68e8/ntedit.cpp#L469

Shouldn't the line read (I'm not sure):

bool solid_if_count = !bloom.is_counting() || (bloom.get_count(hVal) >= opt::min_threshold && bloom.get_count(hVal) <= opt::max_threshold);

Also, related to our discussion on eliminating filters based on median in favour of a simple k-mer presence (as with a regular BF): line 1767:

     if (bloom.is_counting()) {
                                                        best_num_support = check_there_median;                       
                                                } else {
                                                        best_num_support = check_there;
                                                }

here we assign best_num_support (for reporting, but also for filtering -- see line 1870 ). if (check_present >= best_num_support) { If I'm not mistaken, the median coverage is compared here.