bcgsc / orca

:whale: Genomics Research Container Architecture
http://www.bcgsc.ca/services/orca
GNU General Public License v3.0
48 stars 13 forks source link

dockerfilelint to dockerfile_lint #51

Closed suujia closed 6 years ago

suujia commented 6 years ago

ignore errors of sudo use and :latest tag

see https://github.com/bcgsc/orca/pull/50 for more info

suujia commented 6 years ago

ok i see. looks like these crazy commits will follow me around :sweat_smile: my bad

unsure why the previous commits removing poretools that have already been merged is still showing up in this pull request.

sjackman commented 6 years ago

I believe the committed dockerfile_rules.yaml overrides the default set of rules. I've opened an issue at https://github.com/projectatomic/dockerfile_lint/issues/110 to ask how to override the severity of a default rule. In the mean time, please use dockerfile_lint -e >dockerfile_rules.yaml to export the default rules. and commit that default set of rules. Then we can modify the default set to suit our purpose.